Todo App with Styled Components and React

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Eric, I took some time to look at your solution and you did a great job!

  You can fix the height with min-heigth: 100vh.

  Also instead of using px try to use relative units of measurement -> read here

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  2
• 

  P

  Dave•5,295

  @dwhensonPosted over 2 years ago

  Hey Eric - what's the issue with the 100vh? It seems to be working OK to me? Your solution looks lovely!

  I'm not familiar with React, but I wondered if you could possibly improve the semantics of the HTML? Ideally you could wrap all the todo items in a ul and make each todo item an li?

  Last small suggestions is to make the delete images a bit more obvious and wrap them in a button so that they are also nice and semantic. Again I don't know how possible this is in React?

  Lovely job though - this one is tricky!

  Cheers 👋

  Dave

  Marked as helpful

  1
• 

  Eric•260

  @ehlabradaPosted over 2 years ago

  Thanks for all your suggestions and feedback, I really appreciated I'm not pretty good at semantic HTML I try do my best but always keep forget something, and what you say can be done with React I don't if you can't see it but when I use the developer tools from the browser the html and body tag doesn't grow beyond the content .

  0