Todo App with ReactJS

Community feedback

• 

  Jeffry Delgado Sanchez•0

  @JefDel2190Posted almost 3 years ago

  Hi, one question. How did you solve the problem of the user agent stylesheet in the browser in case you had it?

  0

  ---

  

  CY•140

  @cyisherePosted almost 3 years ago

  @JefDel2190 For this one, I used the code below. And for most of my other projects, I use Eric A. Meyer's CSS reset.

  *,
  *::before,
  *::after {
    box-sizing: border-box;
    margin: 0;
    padding: 0;
  }
  

  0

  

  Jeffry Delgado Sanchez•0

  @JefDel2190Posted almost 3 years ago

  @cyishere Thanks for answering, I'm going to try this solution to see if it works for me and if it doesn't work I'll keep looking.

  0

  

  CY•140

  @cyisherePosted almost 3 years ago

  @JefDel2190 You're welcome. And I'd like to recommend these two articles to you 1) A Modern CSS Reset, 2) My Custom CSS Reset.

  0
• 

  Kristian Dunne•305

  @KristianDunnePosted almost 4 years ago

  Nice implementation CY!

  You should look at using styled-components or CSS modules alongside your components to have the styles scoped. Would be much nicer than having to go back to a global stylesheet.

  Great work!

  2

  ---

  

  CY•140

  @cyisherePosted almost 4 years ago

  @KristianDunne Thank you, Kristian. I just can't switch my mindset to styled-components thing, for now, I'll keep trying. 😄

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Y Chen 👋

  Great job on this challenge , I liked it's responsiveness , adding background-size:contain can take the entire width for the top image !

  Overall great job , Happy coding 😇

  2

  ---

  

  CY•140

  @cyisherePosted almost 4 years ago

  @abhik-b Thank you. I totally forgot this property... I've fixed it.

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hello there, Y. Chen! 👋

  Well done on this challenge! 👍 The to-do list works pretty well except new items aren't appearing on the to-do list when I add them. You might want to consider looking into that! 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  CY•140

  @cyisherePosted almost 4 years ago

  @ApplePieGiraffe Thank you for the reminder! I tested it on my computer before I put the code on codesandbox. I didn't realize it... I'll fix it.

  1

  

  CY•140

  @cyisherePosted almost 4 years ago

  @ApplePieGiraffe I've fixed it. Happy coding! 😄

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  @cyishere

  Just took another look, and adding new items to the to-do list works just fine, now. 👍 I think a good idea would be to prevent users from submitting empty to-do items in case they accidentally hit the "Enter" key without actually writing anything in the text box. 😅

  1

  

  CY•140

  @cyisherePosted almost 4 years ago

  @ApplePieGiraffe Yes, you're right! How stupid I am...🤦🏻‍♀️ Thank you for taking another look.🙏🏻

  1