Todo app with React.js and styled components

Community feedback

• 

  Roc Tanweer•2,500

  @RocTanweerPosted over 3 years ago

  Hello 👋 @Pawel

  Really nice attempt 👍 for this challenge

  I like the transition you have on theme toggler..!

  Suggestions 😃 :

  1. You should always put aria-label to inputs in case they don't have a label for accessibility issue. And there shouldn't be a form without submit button.
  2. Add local storage so save bothe the theme and also the user activity.
  3. Add outlines to every button, input field and custom checkbox for key board user.

  Now your main request 🙂...

  4. What I did, I set that image as background of the header for desktop and mobile as usual. Now I made a class called light and did same thing for light theme. Now I am toggling this class 'theme' and what it does, it overrides the default background-image of header for both desktop and mobile.

  Hope it helps(happy coding..! )

  1

  ---

  

  pawel975•190

  @pawel975Posted over 3 years ago

  Hi @RocTanweer!

  I have fixed accessibility if it goes about add task form and added submit button instead checkbox&span. Also added a theme being saved to local storage. I'm very grateful for your feedback, thanks! :)

  1

  

  Roc Tanweer•2,500

  @RocTanweerPosted over 3 years ago

  @pawel975 My Pleasure..!

  Marked as helpful

  1