Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Praveen, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the tasks for improve the Accessibility - instead of using
px
use relative units of measurement likerem
-> read here - i can add tasks also with blanks, add a control... The
trim()
method can help you -> read here - if I add 2 tasks with the same text when I mark one as completed both are checked, I think it is an
id
problem
Overall you did well 😁 Hope this help!
Marked as helpful0@solvedbiscuit71Posted over 2 years ago@denielden Thanks for the feedback 😊. I will address these issues!
1@solvedbiscuit71Posted over 2 years ago@denielden I have fixed these issues mentioned by you, can you please verify them for me ??
1@denieldenPosted over 2 years ago@solvedbiscuit71 Yess... Now it's much better :) keep it up!
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord