todo app with light and dark mode

Community feedback

• 

  Zineb Boutaa•750

  @zineb-BouPosted over 2 years ago

  Hi there, Good job on this challenge, I am dropping some comments that may help you to improve your solution even further.

  • The App container class=” App” is not taking the full-screen height, so instead of writing height:100vh, min-height:100vh will do the job.
  • I recommend using a different shadow to the to-do list wrapper, it looks a bit odd on the dark mode.
  • Sun/Moon toggle actually it is a button, so instead of using <div>, use <button> with an aria-label=” toggle theme”, since there is no textual indication of the button purpose, we still need to provide alternative text for users who use assistive technology, (the same thing applied to the delete button and the checkbox)

  Happy coding

  0