Todo App, Vanilla Js

Community feedback

• 

  P

  Grzegorz Sterczewski•680

  @gsterczewskiPosted almost 4 years ago

  Hello Leonel,

  I like your work on this 👍. Your js is well organized and easy to understand, which I struggle with.

  I have a few suggestions :

  • Consider adding label to .input__todo , since it would help with accessibility. -I think your could tweak box-shadow on .todos since in blends with the background on light mode too much. -It would be nice to add some better support for keyboard users, e.g. set focus on todo and mark it or delete it with key press. Right now I can only set focus on .input__todo
  • How about setting cursor:poiner on .header__theme-switcher to indicate that this element is interactive?

  Anyway, thats my suggestions for little improvements, overall you did great job 👏.

  Have a good day. Cheers!

  0

  ---

  

  Leonel Meque•255

  @leonelmequePosted almost 4 years ago

  @GSterczewski Thank you for the tips, I will make the changes when I get the chance.

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hi Leonel ,

  You have done a great job on this challenge , I really liked the class based approach you took💯.

  Great job 👌👌

  Keep it up 💯

  0

  ---

  

  Leonel Meque•255

  @leonelmequePosted almost 4 years ago

  @abhik-b Thank you so much

  0