Todo app using ReactJS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, mi souto! 👋

  Nice work! Your solution looks good and the drag-and-drop functionality works great! 👍

  However, I don't seem to be able to delete items from the to-do list by clicking on the "X" icon (it marks the to-do item as completed instead). You might want to look into that to see what's going on. 😉

  I also suggest switching to a mobile-friendly layout a little sooner to prevent the content of the page from looking too squeezed or anything (some of the content gets cut off the screen a little) right before the layout changes.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  P

  mi souto•105

  @mileinePosted almost 4 years ago

  @ApplePieGiraffe, I appreciate your feedback! 🙏

  Yeah, you're right... there's sth going on with the "X" icon... I totally missed it! This is so embarrassing, but I'll get it done ASAP. I really need to spend more time planning before coding... 😅

  Yesterday I noticed the content gets cut off on my phone, then I started wondering if I needed an extra breakpoint... But I'll test just switching to mobile-friendly a little sooner as you suggested. Thanks again! 😊

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Good work Mi 👌

  1. you can use the circle in input as a button and set it's type to submit that will fix the acccessibility issue

  2. unfortunately I could not see your github code but I hope after you refactor all your html issues will be fixed

  1

  ---

  

  P

  mi souto•105

  @mileinePosted almost 4 years ago

  @abhik-b, thank you so much for your feedback! 🙏 I'll use the circle in input as button as you said. I also changed my repo visibility to public. Perhaps I should also be saying: "Excuse... the mess?" 😅 Unfortunately, I didn't take enough time to plan before code, now I have a lot of refactoring to do.😱 Lesson learned for next time. 😇

  0