Todo App Challange

Community feedback

• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Hey Marco 👋 First of all I would like to make this very clear your Javascript code is not bad at all, rather it is better than a lot of devs(including me)💯.

  Your final product is really amazing and transitions have given life to it👏👏👏

  However you can improve it (these are just opinions only)

  1. add overflow: hidden so that when your theme changes the animation is smooth
  2. for changing theme you have created a big function however you can minimize it a 5-6 lines function using css variables this is how I did while creating this solution you can use it as a reference
  3. instead of img tags you can use div tags and set background-image for different media queries using css and then probably animate the div inside the function you create in point 2
  4. I have been told that setting innerHTML is not safe to use , even though it's perfect for this solution but later on try to avoid it on real projects other wise it can be used to insert malicious scripts by hackers

  Assuming that you are a javascript beginner , you have done amazing job , most importantly you have a great sense of design as I see through our solution.

  Hope this helps 🙏

  2

  ---

  

  Marco•265

  @MarcoCarpoPosted almost 4 years ago

  Hey @abhik-b! Thank you so much for all your tips, I will try to apply them to improve myself for the next challenge!

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hey, Marco! 👋

  Nice job on this challenge! The transition between light/dark themes is pretty cool! 😎 Your todo list works rather well, too! 👏

  I suggest,

  • Taking a look at your solution report and making the elements of the page more accessible.
  • Perhaps allowing users to check items off the todo list by clicking on the title of each todo (rather than just the checkmark bubble) to make checking things off a little easier.

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Marco•265

  @MarcoCarpoPosted almost 4 years ago

  Hi @ApplePieGiraffe, in fact there are still some elements that could be more accessible, I will try to improve them, thank you very much for your feedback!

  0