Todo app

Community feedback

• 

  P

  Matthias•630

  @astrageniusPosted over 2 years ago

  Hey your bg-images and icons dont load correctly.

  Remove "/" on all your img url path.

  for example:

  body {
      --bg-img: url("/images/bg-mobile-dark.jpg");
  }
  
  to
  
  body {
  
      --bg-img: url("images/bg-mobile-dark.jpg");
  }
  
  

  do this on all your image urls. After this all images should load correctly.

  Marked as helpful

  0

  ---

  

  Duyen Nguyen•950

  @Duyen-codesPosted over 2 years ago

  @astragenius Hey! Thanks very much for your help! I was wondering why my images don't load correctly even though they show just fine through live server on my pc. Thanks again!

  0
• 

  Progress Aienobe•565

  @PaienobePosted over 2 years ago

  To do the deleting, you could push all the items added to the list to an array and then when you want to delete something, you can use filter method and return only the items not equal to the item you want to delete. Hope this helps

  Marked as helpful

  0

  ---

  

  Duyen Nguyen•950

  @Duyen-codesPosted over 2 years ago

  @Paienobe Hey! Thanks for your time helping! I basically know the logic of deleting items from array, but visually somehow when I click the cross icon, the whole thing does not disappear. I'm still trying to figure out why. When adding the todo item, I use insertAdjacentHTML, I dont know if that affects the thing. This challenge seems to be over my head :(

  0
• 

  imNotAli•230

  @AliNaderiiPosted over 2 years ago

  Hey there :) Well, I tested your code and this is what I found.

  • Your querySelectorAll is not working as it should and when I used getElementsByTagName it worked properly.
  • The way that you are using spread syntax is not needed, querySelectorAll returns an array by default.
  • What you are pushing to todoItems is not necessary, you could just use querySelectorAll.
  • I think it's better to use createElement and then appendChild instead of insertAdjacentHTML.

  I hope you find it helpful :)

  0