Todo app

Community feedback

• 

  J.D. Browne•870

  @PeshwariNaanPosted about 2 years ago

  Hello Ammar - great job on completing the challenge. The functionality works well and the responsiveness is very good.

  Here are a couple tips that might help with your code:

  • Try to make everything modular when using React. The thing that makes React good is that it only renders the things that change to the real DOM. If you don't break up your code into different components, you will have lots of unnecessary re-renders for components that don't need to change. For example, you could split up the todolist component and make the todo items a separate component and then map them into the list. Also take the taskbar that is coded in the todolist component and make it a separate component. This way you only re-render what needs to change and your code will be much more efficient. You can take a look at my solution if it helps here. You can also see how I implemented the drag and drop using beautiful dnd if you would like to add that to your project.

  • For the input component, don't enable the check-mark in the circle. There is no reason to have a check on the input. I made mine so it will clear the search field when clicked instead.

  I hope you find these tips helpful - Happy coding

  Marked as helpful

  1

  ---

  

  Ammar Jalabi•270

  @AmmarCodePosted about 2 years ago

  @PeshwariNaan Thanks for the good feedback! I refactored the code. I broke it into more components and disabled the check mark on the form. I might try to do drag and drop sometime later if I had free time.

  0