Design comparison
Solution retrospective
Hello, this is my solution of the todo app.
It have a problem that doesent let me change the complete state of the task, i tried with a lot of things but i didnt get it, i used a cutom hook to manage all the functions and the data, the problem is that i cant manage the state of the task directly in the task... I'll appreciate any feedback
Community feedback
- @denieldenPosted over 2 years ago
Hi Angel, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the tasks for improve the Accessibility - add
transition
when change the dark/light mode - instead of using
px
use relative units of measurement likerem
-> read here - when i click *completed or clear completed * all task scompare
- i can add task also with blanks, add a control... The
trim()
method can help you -> read here
Overall you did well 😁 Hope this help!
0@calliou24Posted over 2 years ago@denielden
Hello, thank you for the feedback, for now i solve the main accessibility problem, add the transition property to my app, and add some control to the add function, using the trim method, i also add a toast notification when the user tries to add an existing task. The projects still have the filters problem but I'm working on it :)
I also have in mind start using the relative units of measurement... ty.
1 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord