@denielden
Posted
Hi Angel, great work on this challenge! 😉
Here are a few tips for improve your code:
- add
main
tag and wrap the tasks for improve the Accessibility - add
transition
when change the dark/light mode - instead of using
px
use relative units of measurement likerem
-> read here - when i click *completed or clear completed * all task scompare
- i can add task also with blanks, add a control... The
trim()
method can help you -> read here
Overall you did well 😁 Hope this help!
@calliou24
Posted
@denielden
Hello, thank you for the feedback, for now i solve the main accessibility problem, add the transition property to my app, and add some control to the add function, using the trim method, i also add a toast notification when the user tries to add an existing task. The projects still have the filters problem but I'm working on it :)
I also have in mind start using the relative units of measurement... ty.