Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi Rodrigo, good job! I took some time to look at your code and have some ideas for improving it:
- add
main
tag and wrap the page content for improve the Accessibility - to make it look as close to the design as possible add
background-size: cover and max-height: 20rem
tobackGroundDark
class and movebackground-color
to body or parent container - use
min-height: 100vh
iinsteadheight
- i can add a task also with blanks, add a control... The
trim()
method can help you -> read here
Hope this help and happy coding!
Marked as helpful0 - add
- @rodrisapiensPosted over 2 years ago
wow man! thanks a lot for the feedback! I will take it :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord