Skip to content
Submitted about 2 years ago

To center the card i use flex-box

rash•50
@R-CODE01
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,400
    @correlucasPosted about 2 years ago

    👾Hello @R-CODE01, Congratulations on completing this challenge!

    Here's one tip about alignment:

    The approach you've used to center this card vertically is not the best way, because using margins you don't have much control over the component when it scales. My suggestion is that you do this alignment with flexbox using the body as a reference for the container.The first thing you need to do is to remove the margins used to align it, then apply min-height: 100vh to make the body height size becomes 100% of the screen height, this way you make sure that whatever the situation the child element (the container) align the body with display: flex and align-items: center / justify-items: center.

    Body {
    min-height: 100vh;
    display: flex;
    align-items: center;
    justify-content: center;
    flex-direction: column;
}

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
    rash•50
    @R-CODE01Posted about 2 years ago

    @correlucas Thank uuuu I get it

    1
  • Kawsar Ahmed Fahad•2,660
    @faha1999Posted about 2 years ago

    Hello, rash Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

    You might want to use semantic tags like the <main> to wrap your code, instead of div `s.

    • You might want to use semantic tags like the <main> to wrap your code, instead of div. like
    <main>
      <div class="container""></div>
      <div calss="attribution"></div>
</main>

    You could also make use of <section> and/or <article> semantic tags. This would help improve accessibility.

    • add these to the body
    body{
justify-content: center;
    align-items: center;
    display: flex;
    height: 100vh;
    background: hsl(212, 45%, 89%);
}

    I hope this helps you. Happy Coding!

    Marked as helpful
    1
    rash•50
    @R-CODE01Posted about 2 years ago

    @faha1999 thank u i will try it

    0
  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi rash, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord