Design comparison
Solution retrospective
This challenge is pretty easy so I use this to practice webpack and setup prettier,eslint...Trying to understand how to setup development environment closer to real work scenario, can you guys share how your setup was? Or give me some feedback about my setup.
Community feedback
- @AlexKMarshallPosted almost 3 years ago
This is looking good. Careful with some of the semantics though.
There should only be one form. All the inputs should be wrapped in that form as they are part of the calculation, don't have a form for each individual input.
The type of your reset button should either be "button" or "reset". Buttons that are inside a form get a default type of "submit". So at the moment, when you reset the form it's causing a form-submission and a full page reload.
Your build setup looks good. Using husky and lint-staged is very useful.
0 - @molszewski34Posted almost 3 years ago
Hey. You miss one small feature. It is not so important but without it project is not complete. When reset button is used it should change style to darker to look as it is disabled and when there is any change it should look active again.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord