tip-calculator-app-main using vanilla JavaScript

Community feedback

• 

  Damilola Mohammed•230

  @activus-dPosted over 2 years ago

  @maruf1137 @EtnoPolino thanks to you guys. Got the code refactored with special help from @maruf1137 solution.

  0

  ---

  

  Etno Polino•180

  @EtnoPolinoPosted over 2 years ago

  @activus-d It looks good now. Annoying how all this work depending of the navigator browser you're using.. You also used <input type=number">, on Chrome you cant write non numeric number on your input, but on firefox you can.

  0

  

  Damilola Mohammed•230

  @activus-dPosted over 2 years ago

  @EtnoPolino yes it's so annoying. Although on entering Firefox would not allow the input to be submitted unless the characters entered are numeric. I'm reading on stackoverflow how to prevent this with the regex. Just maybe I would try using regex on the input and see for myself if it would help with the issue.

  0
• 

  Damilola Mohammed•230

  @activus-dPosted over 2 years ago

  @maruf1137 @EtnoPolino the code works only that if it is a custom tip you have to press the enter key to display the result. I understand this makes it hard to know how to use the app, so I'm getting some inspiration from @Maruf1137 solution to the challenge to refactor my code so that it displays results live while taking input instead of waiting for some event. Would update you guys once it's done. I hope you will give feedback again after then. Thank you.

  0
• 

  Maruf•60

  @maruf1137Posted over 2 years ago

  I think it's everything is good. but I saw a problem that is calculation doesn't work.

  0

  ---

  

  Damilola Mohammed•230

  @activus-dPosted over 2 years ago

  @maruf1137 the calculation works. Have you tried it?

  0

  

  Etno Polino•180

  @EtnoPolinoPosted over 2 years ago

  @activus-d He has a point. Your custom calculation doesnt work.

  0