Tip-calculator-app-main

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Great job completing this challenge successfully and making it fully responsive! Looks great overall.

  My suggestion would be to set the breakpoint for switching to mobile view a bit higher as in tablet view, sometimes the page content overflows the viewport. E.g. 880px as a breakpoint could solve this. Tablet design is usually for 768px, so it will cover this as well.

  Hope you find this feedback helpful!

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  HTML 🏷️:

  • An h1 heading should primarily be used to identify the content on the specific page within the website and be placed at the beginning of the main content to provide an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • Including both a main landmark and an h1 element provides a redundant way for users of assistive technologies to find the main content of a web page.

  SUMMARY:

  • If the page contains h1 element and either a main or banner landmark, the h1 element must be a child of either the main or banner landmark.

  ---

  • NOTE: h1 must be in main or banner landmark

  ---

  • So, nest the <h1>Spli tter</h1> inside the main element

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0