tip-calculator-app-main

Community feedback

• 

  szam•800

  @k-stopczynskaPosted about 2 years ago

  Hi!

  Congratulations on finishing the challenge!

  I have two suggestions based on testing live version:

  1. You did fix the outcome but didn't prevent the user from inputting values like: 123,567789 and they do appear as a tip value as user is typing and overflowing the container.

  2. I can easily set No. of people and bill amount to negative numbers as well as get custom negative tip, you probably don't want that (simple min value on the input field would do the trick).

  Overall nice job, happy coding!

  Marked as helpful

  1

  ---

  

  Gian de Faria•290

  @giandefariaPosted about 2 years ago

  @k-stopczynska Hello!

  Initially sorry for my english, is not my native language. I fixed the two errors you are suggested.

  Thanks for your feedback!

  0