tip-calculator-app

Community feedback

• 

  Elaine•11,400

  @elaineleungPosted over 2 years ago

  Hi To Dat, well done completing your first Junior project! I think you did a great job here, everything worked fine for me 🙂

  If you want to hide the number spinners, you can try adding this in the CSS:

  // For Chrome and Safari
  input::-webkit-outer-spin-button,
  input::-webkit-inner-spin-button {
    -webkit-appearance: none;
    margin: 0;
  }
  
  // For Firefox
  [type="number"] {
    -moz-appearance: textfield;
  }
  

  About the icons, what I did in my solution was to use a pseudo element with position absolute; since it's just an icon for decoration, I think it's fine to use a pseudo element here. There was another challenge where instead of absolute positioning inside an input, I used flexbox; I think it just depends on what you want to achieve in the end, because I think I added some animation for that challenge with the icon.

  I noticed that you used a number array for the buttons, which I think works, even though the code is a bit clunky to read due to all the index numbering. In my solution I hardcoded the values into the inputs and then retrieved that value to work with; that's something you can try as well in the future. You can check out my solution here.

  Keep going, you can do it! 😊

  Marked as helpful

  2

  ---

  

  To Dat•290

  @tltd0807Posted over 2 years ago

  @elaineleung thanks very much, I'll try

  1