tip-calculator-app

Community feedback

• 

  Abhik•4,840

  @abhik-bPosted almost 3 years ago

  👋 Hello Flavio , Your solution is nice & I have peeped through your code & I liked the validators & other stuff! Good Job , Well Done 🤩

  Some opinions that you can try :

  • give body display:grid;place-items:center; so that the container always stays on center of screen. But to make this actually work you will also have to remove position:relative;transform:translateY from container & also replace the body's height with min-height:100vh . This can make the site very responsive.
  • since you have started learning html / css 3 weeks ago , I think you should take on easier challenges which does not focus on js . Gradually you will learn & understand & code much cooler solutions 🤩 .

  Please keep coding these wonderful solutions 👍

  0

  ---

  

  Flavio Esrenko Zorzetto•210

  @flaviozorzettoPosted almost 3 years ago

  @abhik-b Hi, thanks for the feedbacks, i'll start learning grid next week, i was focusing first mastering flex then learning grid, but still enjoyed a lot the way you did to center the container.

  I've no problems with js, before learning html/css I studied javascript alone with node, developing API's, etc, so I'm okay with the logical stuff and the language, and I'm just not used to doing it for front-end, with DOM manipulation, etc

  1