Design comparison
Community feedback
- @ortalyartsPosted 7 months ago
Hey @kodan96!
Congratulations on completing the challenge!
I have spotted one little bug: the app starts to calculate before I added/selected all the required fields, which causes it to show result as NaN. You can prevent it by adding an additional validation that will check if all the required fields are filled/selected and only then proceed to the calculation.
Also, the app should not accept "0" as value for Bill or Number of people, it causes unexpected calculations.
Above all, your solution looks really good!
I hope you find this helpful! Cheers 🍭
Marked as helpful0@kodan96Posted 7 months ago@ortalyarts
Thank you for pointing it out, I'll definitely look into it, and fix it later!
I'm still relatively new to programming, so I was glad i managed to pull off this much. 😅😅
Thank you for the feedback, good luck and happy coding! 🤞 🤞
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord