Tip Calculator written in HTML, CSS and Typescript

Community feedback

• 

  achrustowski•150

  @achrustowskiPosted about 2 years ago

  Hi RuFa,

  Congrats on your solution! It looks great and it's a nice touch to have a prompt for Custom tip value :)

  As for improvements, you have some repetitions in you JS code, you could put gridButtons.forEach(btn => { btn.setAttribute('style', 'pointer-events: auto'); btn.classList.remove('btn-clicked'); }); and button.classList.add('btn-clicked'); button.setAttribute('style', 'pointer-events: none'); inside of a function and call it whenever you need to use it. This will clean up the code a little bit and make it more readable.

  Lastly, completely UI thing, looks like your 15% button is clicked by default, not sure if this is intended, just my observation.

  Hope this help! Adam

  Marked as helpful

  1

  ---

  

  RuFa•170

  @RuFuRuPosted about 2 years ago

  @achrustowski Hello achrustowski,

  The 15% button isn't clicked by default. I was a bit confused by the pictures provided by this challange and I though this button was supposed to be differently coloured from the rest.

  I will change it later if it's too jarring

  Thanks for the feedback

  0