Tip Calculator with Svelte, TypeScript and SCSS

Community feedback

• 

  solitary_coder•1,000

  @kabir-afkPosted about 1 year ago

  Hey !! , great job btw , but upon reviewing your sass I realized that you were using pixels quite a lot , which fixes the dimension your of DOM elements making them unresponsive when changing your viewport , it would have been better if you used relative units more , then you wouldn't have had to specify multiple media queries as well . . . I guess you all were trying to achieve was a design accurate webpage , which is ok. As frontend devs we have a knack for pixel perfect webpages , but that's not possible all the time , I recommend you read this article here, I discovered it quite recently as well😅 . . . It will give you a step by step guide on how you can generate a ditto screenshot for your frontend challenges . . enjoy and keep on grinding !!! 💪💪

  Marked as helpful

  1

  ---

  

  P

  Jeremy Helsel•670

  @JIH7Posted about 1 year ago

  @kabir-afk Thank you so much for the feedback! I've been aware for a while I should be using relative units, but just like you said it made it hard to match the design as closely as I'd like. That being said it really is a skill I should be prioritizing at this point since with some of the super simple challenges, I have done pixel perfect designs. I'll take a look at the article and try to incorporate relative units into my next project. Thanks again!

  0

  

  solitary_coder•1,000

  @kabir-afkPosted about 1 year ago

  @JIH7 my pleasure brother 🥂

  0