Tip Calculator with React JS / Sass

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted 11 months ago

  Hi YIAN

  I have gone through your project, here is some things that you can have a look at:

  • there is a logo Splitter that you should use, Splitter is not an h1 in this case.
  • heading elements need to follow a sequential order, where an h1 is followed up by an h2 and an h2 can only be followed up by an h3
  • input elements should have a label to improve the accessibility of your project
  • an id should be unique, you cannot have more than one elements with the same id name. A class is the one that can be reused in several elements.
  • for the percentages , in my opinion , those should have been radio buttons - when you are given several options where one option can be selected at an given time then the choice to use should be radio buttons.
  • the calculations are a step behind when you are selecting the percentages
  • avoid CSS like this .calculator .content .calc-buttons .people-value .people-error-value.error-appear , that declaration will be very difficult to debug and override and is not necessary. Use a single class that you can apply the styles to.

  1