Skip to content
Submitted over 1 year ago

Tip calculator app with React & SCSS

Max Ruuen•290
@ruuen
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

This was a good challenge to further practice the form validation and handling in React that I've learned in the past few challenges.

Any feedback on improvements in the code or best practices I've violated/missed in the React side of things, please let me know!

Community feedback

  • Luka Glonti•3,440
    @lack21Posted over 1 year ago

    Good work 👍, but I have a recommendation!

    • Replace height: 100vh to min-height: 100vh, the difference is that, when you set height: 100vh to something, that means it won't be bigger than that, it might cause some problems in the future, so better approach is to set min-height: 100vh, like this in case content is overflowing container will adjust to it.
    Marked as helpful
    1
    Max Ruuen•290
    @ruuenPosted over 1 year ago

    @lack21 Hey mate, thanks for the advice. I've corrected this now!

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord