Tip calculator

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  Hi!, nice job, well styled and functional. I suggest you take look at following things:

  1- The reset button is disabled becase you've set the disable attibute on it, logically it would makes sance to disable it when the controls are empty.

  2- currently there is an limit for the custom tip procentage which not expected, to limited it quite logical but even if it's really unlikely if somebody wants to give an 10000% procent tip.

  3- At smaller screen sizes there is not spacing between the container and the edegs of the window which is not good for the readability.

  4- I suggest you start looking in a naming convention for your class or even a better choice would be methodology like BEM because it helps you write more clear and structured markup.

  Keep coding :)

  0

  ---

  

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  @MojtabaMosavi got it. Thanks for reviewing

  0