Tip Calculator using Vanilla JS, CSS Grid and Flexbox

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • my expectation was that when i select any button as long as the bill and number of people are valid inputs, then the calculations should be done and displayed. If i put the bill as 100 and number of people as 1 and then select the rate buttons nothing happens, the change only comes when i change the bill or the number of people.
  • the checked attribute can be set to false by looping the radio buttons when the custom input has been selected

  1

  ---

  

  Pandu Mahesa•95

  @pndmhsPosted over 3 years ago

  @ChamuMutezva 1. Sorry, you're right, it doesn't change when you click the rate button. I will fix it

  2. Oh yeah you're right, I didn't think of it. Thanks !

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • the calculator is not working as expected. When the bill and number of people are filled in and then select the buttons nothing changes. Changes only happens when the number of people and bill has been changed.
  • i would have used a radio button instead of a checkbox, since a radio button can only allow one element to be checked at a particular time.
  • negative values are giving me results

  1

  ---

  

  Pandu Mahesa•95

  @pndmhsPosted over 3 years ago

  @ChamuMutezva

  1. Are you sure? It works fine for me.

  2. When you want to input custom tip you need to uncheck the tip options. I don't know if radio button can be unchecked so I used checkbox instead.

  3. Oh thanks for letting me know, I forgot to test the negative number so it didn't excluded in the calculation.

  Anyway thanks for the feedback. I appreciate it very much

  0