Tip Calculator using vanilla JS and pure CSS

Community feedback

• 

  IRVINE MESA•1,855

  @DrMESAZIMPosted over 2 years ago

  hi @John-droid-dotcom I observed that this is your first solution therefore as expected there are plenty of issues to address . I will attempt to give your areas to address

  1.You need to reduce the min-width on your media queries . 1280px is to large 2. the input figure for number of people referred in index.html line 46 show not allow decimal numbers 3.Overall the calculator is not functioning as expected , check out this tip-calculator @kenreibman site address https://kenreibman.github.io/tip-calculator-app/ As a newbie I urge you to start by challenges that don't require complicated JavaScript

  I wish all the best in your career as web developer

  Marked as helpful

  1
• 

  Paola•320

  @paolas771Posted over 2 years ago

  Hello some of you math is wrong in the calculate function else statement. The billamounttotalperson should be the (tip amount + bill total) / number of people. What you are doing is taking the tip amount and multiplying it by 2 which there is no need. On the billamountperperson you should do (bill amount * tip value) / number of people. I would also recommend doing an event listener on the number of people input instead of the tip button just cause the user will be filling out the form from top to bottom. Other you did a good job!!

  Marked as helpful

  0

  ---

  

  Yohannes Teshome•50

  @johannesteshomePosted over 2 years ago

  Thank you it was my very first project thanks for the feedback. @paolas771

  0