Design comparison
Solution retrospective
This is my second project using Javascript. I was able to get the functionality I wanted for the most part but my JS is clumsy. Mainly I think I could have encapsulated it better instead of having so many snippets of code. Any feedback about that would be great.
Thanks!
Community feedback
- @Fitsos17Posted over 2 years ago
Hey man. Great job with your solution👍! One thing that I noticed searching your code is in your header tag you said
<h1>SPLI<br />TTER</h1>
. I think that there is no need for that. Check images folder and you'll find an svg file that is named logo. You can use this directly to your app via an img element. It contains everything you wrote. Just style that img tag and you'll be ready to go!Marked as helpful0@JohnsonworldPosted over 2 years ago@Fitsos17 Thanks very much! I totally missed that svg file!
1@Fitsos17Posted over 2 years ago@Johnsonworld No problem man. Trust me, I did the same mistake. Overall very nice app. Keep up the good work!
0 - @JohnsonworldPosted over 2 years ago
I should add that I struggled with some tab index issues and solution report called that out - I'll clean that up and a couple of miscues in the html and resubmit.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord