Tip Calculator Using Vanila JS

Community feedback

• 

  Rohail Taha•355

  @rohailtahaPosted over 3 years ago

  The solution is great. Since you asked for suggestions and they are always good for beginners, so I'll give some:

  1. Try avoiding the 'height' property and use 'min-height' instead as it makes responsive designs easier.
  2. If you don't know, try learning about 'rem' and 'em' units and use them for font-sizes, margins and paddings.
  3. Try giving more specific and easy to remember class names. Instead of .inputdiv1, .inputdiv2, you can think of class names that are more relatable like input_bill, input_persons.
  4. Instead of one long function try to divide it into smaller functions that do one particular task. The code becomes easier to read and refactor later on.

  At last I would suggest you to checkout this channel (Maybe you have already). It is simply one of the best for learning css tips and good pratices. You will not regret following this channel. https://www.youtube.com/channel/UCJZv4d5rbIKd4QHMPkcABCw

  Marked as helpful

  1

  ---

  

  Abdullah Chowdhury•135

  @AbdullahUCPosted over 3 years ago

  @Rohail77 Thank you so much friend for your effective suggestions. I am very much pleased with your suggestions. I will try to improve my coding skill by following your steps. Keep this good work and keep helping..

  Happy Coding!!

  1
• 

  Hafizan Adli•1,190

  @hafizanadliPosted over 3 years ago

  Hi, appreciate the effort you did

  Here are some suggestions from me

  • It's not common to put the js and css file in assets folder. You can create scripts folder for js file and styles folder for css file
  • there is a bug when I type on number of people input, and delete it, it always become 1
  • you should try using semantic html, instead of using too many div tag. It would make your code easier to read.

  Hope it can help you to improve Keep up the good work!

  Marked as helpful

  1

  ---

  

  Abdullah Chowdhury•135

  @AbdullahUCPosted over 3 years ago

  @hafizanadli Very much thanks for your helpful suggestions. I think these short suggestions are the key to success in programming life. I will try to fix the bug that you mentioned. Keep up this good work friend. Keep helping!

  Happy Programming!!

  1