Tip calculator using scss..

Community feedback

• 

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  Hi there. You did a good job 😎

  keep improving your programming skills

  your solution looks great, however, if you want to improve it, you can follow these steps:

  ✅ please add transitions for buttons. It allows you to add some effect when an element changes from a state to another.

  ✅ don't use tag selectors. When you add CSS directly on tags, your markup can’t change. Your style is tightly coupled to your DOM, and any change increases the risk of breaking things.

  ✅ use code formatters (prettier, stylelint) for better code structure

  ✅ You Should Stop Using Pixels. They are static and aren’t truly relative to the root font-size like REM and EM units

  ✅ choose a naming convention , methodology, or framework and stick to it. A lot of variables have different name style

  const totalPeoples        =   document.getElementsByClassName('left__total_peoples_input')[0]
  const custom_button       =   document.getElementsByClassName('left__button_custom')[0]
  const custom_input        =   document.getElementsByClassName('left__custom_input')[0]
  const message             =   [...document.getElementsByClassName('left__message')]
  const right__tip_amount   =   document.querySelector('.right__tip_amount > p')
  const right__total_amount =   document.querySelector('.right_total_amount > p')
  

  I hope my feedback will be helpful. You can mark it as useful if so 👍

  Good luck and fun coding 🤝⌨️

  Marked as helpful

  1

  ---

  

  krishna•230

  @krishna8223Posted over 2 years ago

  Hello @isprutfromua

  Thanks for your feedback .I will work on these points...👍

  0

  

  Ivan•2,630

  @isprutfromuaPosted over 2 years ago

  @krishna8223 Hi there

  I am glad that my help was useful to you

  Cheers, peace and happy coding!

  0