Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
In a refactoring in the future, I would focus more on the accessibility part and use some framework, probably react
What challenges did you encounter, and how did you overcome them?Using the ITCSS methodology was the biggest challenge
What specific areas of your project would you like help with?In terms of accessibility
Community feedback
- @huyphan2210Posted 2 months ago
Hi, @danielbasilio
I took a look at your solution and have a few suggestions:
- For accessibility, I assume you're familiar with semantic HTML. I'd encourage you to think about what other elements you could use instead of
<div>—there are plenty of block-level elements that could improve both structure and accessibility. - Your
.containerisn't centered on my 1920x1080 screen, and that's because of themax-width: 1440pxyou've applied. Simply removing this should fix the issue. - Also, you don't need
height: 100vhon.containerbecause it forces thecontainerto always match the viewport height, which can cause overflow issues or create extra empty space. Instead, applyingmin-height: 100vhto thebodyensures the page fills the screen without restricting the container's natural height, allowing it to grow as needed.
Hope this helps!
0 - For accessibility, I assume you're familiar with semantic HTML. I'd encourage you to think about what other elements you could use instead of
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord