Huy Phan• 1,360
@huyphan2210
Posted
Hi, @danielbasilio
I took a look at your solution and have a few suggestions:
- For accessibility, I assume you're familiar with semantic HTML. I'd encourage you to think about what other elements you could use instead of
<div>
—there are plenty of block-level elements that could improve both structure and accessibility. - Your
.container
isn't centered on my 1920x1080 screen, and that's because of themax-width: 1440px
you've applied. Simply removing this should fix the issue. - Also, you don't need
height: 100vh
on.container
because it forces thecontainer
to always match the viewport height, which can cause overflow issues or create extra empty space. Instead, applyingmin-height: 100vh
to thebody
ensures the page fills the screen without restricting the container's natural height, allowing it to grow as needed.
Hope this helps!
0