Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Tip Calculator using sass and css flexbox

P

@danielbasilio

Desktop design screenshot for the Tip calculator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

In a refactoring in the future, I would focus more on the accessibility part and use some framework, probably react

What challenges did you encounter, and how did you overcome them?

Using the ITCSS methodology was the biggest challenge

What specific areas of your project would you like help with?

In terms of accessibility

Community feedback

Huy Phan 1,360

@huyphan2210

Posted

Hi, @danielbasilio

I took a look at your solution and have a few suggestions:

  • For accessibility, I assume you're familiar with semantic HTML. I'd encourage you to think about what other elements you could use instead of <div>—there are plenty of block-level elements that could improve both structure and accessibility.
  • Your .container isn't centered on my 1920x1080 screen, and that's because of the max-width: 1440px you've applied. Simply removing this should fix the issue.
  • Also, you don't need height: 100vh on .container because it forces the container to always match the viewport height, which can cause overflow issues or create extra empty space. Instead, applying min-height: 100vh to the body ensures the page fills the screen without restricting the container's natural height, allowing it to grow as needed.

Hope this helps!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord