Design comparison
SolutionDesign
Solution retrospective
Is the file structure of my app good? Is there a better way to do it? Is my code consistent and well organize? Is my code effecient?
Community feedback
- @SamadeenPosted over 2 years ago
Hey!! Cheers 🥂 on completing this challenge.. .
Here are my suggestions..
- You should nest all your
div
headings
andimg
in amain
tag. - You can wrap your attribution section in a footer tag to avoid accessibility issues.
This should fix most of your accessibility issues
. Regardless you did amazing... hope you find this useful... Happy coding!!!
Marked as helpful1@HazipanPosted over 2 years ago@Samadeen Thank you for the feedback! And thank you especially for commneting on my accessibility in the solution. Accessibility is not something I think about a lot, and I need to focus on it more. I'm going to implement your suggestions. Thank you!
0 - You should nest all your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord