Tip Calculator using JS and SCSS

Community feedback

• 

  achrustowski•150

  @achrustowskiPosted about 2 years ago

  Hi Leo!

  I really like your solution, logic works as expected and everything does it's job as it should, well done! :)

  As for reducing the amount of getElementById I don't think there is any other way if you're using vanilla JavaScript (I've done my solution similar way to yours). Only thing I'd change in order to make your life easier IF you had to edit your JS code, I'd put throwErrorMessage selectors into variables same as you did for buttons and inputs.

  Great job!

  Marked as helpful

  1

  ---

  

  Leo•440

  @SouiciaPosted about 2 years ago

  @achrustowski Thanks for answering! And yes, I kinda guessed there shouldn't be a way to getElementById in bulks mainly when they have different functions. I just thought if a page has 50 of them, it would be a pain to write all of them, so I just asked in case :D. And you're correct about the throwErrorMessage function. It would have made a less bulky function. I was just really tired of writing new variables up there haha!

  0