Design comparison
Solution retrospective
hi!!! frontend mentors After looking at design, I could not find that when should calculator show results like there was no button(shown in design). So, I just made results appear when we select tip percentage. Can you tell me whether it is right or wrong?
Community feedback
- @hardy333Posted about 3 years ago
Hi, nice solution.
Few suggestions for your design to make it more close to design:
- use more padding on inputs.
- use wont weight of 700 on input labels.
- In general you can use more white space - meaning use more padding and margin, it will make your design look more pleasing to eye.
For html:
- use buttons for Select Tip values, div-s are not every good choice in that case.
And for your question:
- Start calculating results only after user selects all three values: bill, tip and number of people, what will be perfect time for that.
The way you did it is also fine but little bit weird, because lets say I firstly want to select tip then bill and after that people your calculator shows warning - red outline on bill input even so I didn't entered any value there. So ya change that logic if you can ... Good luck.
Marked as helpful3@Vee339Posted about 3 years ago@hardy333 Thank you so much for replying. I will consider your suggestions.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord