Design comparison
Solution retrospective
Hi everyone feedback is appreciated :)
Earlier I used the .before
function in javascript to make the error spans but then wasn't able to remove the only one which I wanted Like is there any way that I can do this. Since in this first I have to check if there is the error class before the bill input or before the people input and then remove that one which I want. As I was only able to remove all the span of errors.Like without the use of id.
Therefore I moved to use the HTML and CSS Classes for errors with id.
Community feedback
- @shashreesamuelPosted over 2 years ago
Hey good job completing this challenge.
Keep up the good work
Your solution looks great however I think that the text is a bit too much small for the input fields. Secondly the button background for the calculator itself is supposed to match the color specified in the
style-guide.md
file.I hope this helps
Cheers Happy coding š
1@tab21Posted over 2 years ago@TheCoderGuru Hi
Thanks for going through the code. I did take all the colours from the
style-guide.md
and in it only it was given that input should be24px
thus it is 24px. But now I think that the Answer Could have been bigger which I did :).0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord