Tip Calculator That Calculates Tips (always tip your servers :) )

Community feedback

• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  hi,

  1. You did not add icon on both the input.
  2. You didnot consider the scenario when user enter huge number. You design breaks when output is huge. 3.Limit the decimal place to only two digits.
  3. I saw the result shows "infinity".
  4. Give the maximum tip percent.

  Good luck, happyCoding

  1
• 

  Sara Dunlop•430

  @RiscloverPosted over 2 years ago

  Hi! You commented on my solution for the same challenge (about the logo/h1 element issue), so I came over to check yours out. I'm glad I'm not the only one who did the Reset button colors like how we did them.

  I like how you made it so that the People number automatically begins with 1 as well. Very smart!

  0

  ---

  

  Andy•520

  @AndyAshleyPosted over 2 years ago

  @Risclover Yeah I overlooked quite a few things on this one apparently. The logo, the reset button, the icons lol. Maybe it will help my attention to detail in the future by remembering this one :P . I think if I redid it now I would set the opacity of the reset button to something really low and change it back to 1 when a tip amount was being generated. I'm so used to react that going back to vanilla JS is sometimes a challenge for me. Thanks!

  0