Design comparison
Solution retrospective
Hi!, I built this using scss , i'm not sure if implemented it correctly since it was my first time using it . If not what should i do to implement my scss correctly, feel free to give feedback. Thank You :)
Community feedback
- @matt-o-westPosted about 2 years ago
Looks good! As far as I can tell your javascript is working as intended - peeking at the code, it looks like you're using var to declare some variables, just a reminder that this is deprecated and will hoist your variables. The only thing I would nitpick is your tablet and mobile responsive layouts, they are usable but you could tweak them so the user doesn't need to scroll, and so that the spacing is reduced between elements/font size is reduced etc. Great job, hope this helps!
Marked as helpful0@reymartvigoPosted about 2 years ago@matt-o-west noted sir, thank you for your feedback.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord