Design comparison
Solution retrospective
I am very happy for completing this project. I think that i slightly improved the way that I am writing code. I used some of the techniques that this learning path provided us with.
What challenges did you encounter, and how did you overcome them?The main think that I struggled with is how to break my code into smaller functional pieces.
What specific areas of your project would you like help with?I think that I need to work further on how to right less code. Also I think that I need to name CSS classes in a more efficient way.
Community feedback
- @35degreesPosted 3 months ago
Amazing JS code, it looks efficient and clean, and I like how you wrapped all the initial data into one object. The custom tip box is really well done. I see that you included the warnings into your JS code but I didn't find the warnings after some testing on the actual calculator. Also the layout of your calculator goes haywire if someone enters a huge number like $1,000,000. You should have a warning or a 'maxlength' on your inputs to prevent that. Also adding a .toFixed(2) to control the decimals places makes a better user experience. The mobile version is solid, nice work!
Marked as helpful0@dimitrisdrPosted 3 months agoThanks a lot @35degrees for your suggestions!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord