Tip Calculator - JS | HTML/CSS

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

• I have other recommendations regarding your code that I believe will be of great interest to you.

.

HTML 🏷️:

• This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

• So fix it by replacing the element <div class="attribution"> the with semantic element <footer> in your index.html file to improve accessibility and organization of your page.

• What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

• They convey the structure of your page. For example, The <footer> typically contains information about the author of the section, copyright data or links to related documents.

.

HEADINGS ⚠️:

• This solution had generated accessibility error report due to lack of level-one heading <h1>

• Every site must want at least one h1 element identifying and describing the main content of the page.

• An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

• So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

.

JAVASCRIPT 🟡:

• The way you declared variables are need to be well structured and organized

• Take a look at the following example code which describes an efficient way of declaring variables

const firstName = "Your";
const lastName = "Name";
const emailAddress = "[email protected]";
const password = "supersecret";

• instead try this,

const firstName =  "Your",
       lastName =  "Name",
       emailAddress = "[email protected]"
       •••                
       •••         // n number of declarations
       password = "supersecret";   // make sure to add a semicolon at end of last declaration

• This single line declaration with separated commas will helps you to have a better structured code and improves readability though

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!