
Design comparison
Solution retrospective
I am really just happy, my javascript skills are tested and i completed the project to the best of my ability.
What challenges did you encounter, and how did you overcome them?- The project is a challenge itself but i overcame with research and support from good resources and coding communities like stack overflow.
- Like always, i'd like alternative approaches to how i completed this project.
- I'd also appreciate advice on best practices to solving this project.
Community feedback
- @mbank14Posted about 1 month ago
Hey, great job! I have a few suggestions:
Maybe you could add validation to prevent inputting negative values (-) and letters. You can use regex for validation and add an event listener for 'keyup' or 'keydown' on the input, so the value changes update instantly without needing to click the tip percentage.
For the tip selection, I think using radio buttons would make DOM manipulation easier, and for the custom field, using a number input would be best.
You could create variables like tipPercent, radioPercent, and customPercent. If you select a radio button, set customPercent to '' and tipPercent to radioPercent. If you enter a number in customPercent, set radioPercent to '' and tipPercent to customPercent.
Hope that helps
0 - @kanosayPosted about 1 month ago
- Custom does not work
- All in all everything is good
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord