tip calculator html, css, javascript, flexbox

Community feedback

• 

  P

  Axseinga•430

  @axseingaPosted over 3 years ago

  Hi ellienndea,

  Congrats on finishing this challenge!

  Here are some suggestions from me:

  • you can center your calculator vertically on the desktop design, so it does not stick to the bottom of the page,
  • I would make the "coded by" paragraph much smaller, it looks really big on the desktop and it breaks into two lines on the mobile,
  • you can change the event of event listener to "input" instead of "change" as it was suggested to me as well (I used originally "keyup"). With the "change" your event fires only when User clicks outside after filling the inputs,
  • you can try to break your javascript code into smaller functions so it's more readable :) article about good practices in JS

  I hope it will be helpful for you :) It's not so easy challenge. Great work!

  Marked as helpful

  1

  ---

  

  ellienndea•130

  @ellienndeaPosted over 3 years ago

  @axseinga Hi, thank you so much for your elaborate feedback. Those are all very good points and I will work through them while improving my code for the tip calculator. Happy coding! 😊

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Greetings Ellienndea

  Well done, you did well on this project. The calculation are working well, one thing that you need to take care of are numbers below zero - you validated for zero but not amounts less than zero

  Happy coding

  0

  ---

  

  ellienndea•130

  @ellienndeaPosted over 3 years ago

  @ChamuMutezva Hi Chamu, thanks for your feedback. As it is a tip calculator to calculate the tip for a bill to pay, I would say there won't be any values less than zero. It is not a regular calculator. Thanks anyway! ;) Happy coding!

  0

  

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  @ellienndea, I am imagining a visually impaired accidentally hitting the negative sign and what the confusion might bring

  0

  

  ellienndea•130

  @ellienndeaPosted over 3 years ago

  @ChamuMutezva Thanks for your reply. What would be a good solution for that? An error message or calculating negative values? Don't the screen readers give error msgs? 🤔

  0

  

  P

  Axseinga•430

  @axseingaPosted over 3 years ago

  @ellienndea when you get your billValue you get to add an if statement to it, that if this value is larger than 0 then the rest of the code run (or other way). I noticed that you use only the "let" keyword, we use "let" only if the variable will change (like e.g. counters), have a look at this article about const and let. I noticed as well that you use if(people == 0), you should always use "===" which is strict equality comparison. Have a look here why.

  1

  

  ellienndea•130

  @ellienndeaPosted over 3 years ago

  @axseinga Hi, thank you for your advice and the links. :) I will read them and improve my code accordingly. Happy coding! Linda 😊

  0