Design comparison
Solution retrospective
Hello there~! Sure has been a while since I posted here.
Decided to do a bit of a refresh of knowledge and use react and styled components for this one. Overall, didn't turn out perfect when it comes to the visual side of the project, but I am fairly happy with the functionality.
Any and all advice on how I could improve on various parts is always appreciated though :)
Community feedback
- @tesla-ambassadorPosted about 3 years ago
Hey, the responsiveness is not bad, I like it tbh! The visual end really isn't that bad and the functionality is perfect! The only thing I can help with is the HTML and Accessibility validations. You can't have two "main" tags, it should be one and you also can't have a main landmark within another landmark. That's the only problem, you could opt to use a div to replace the nested main landmark. This will pretty much fix everything. I like your HTML template too! I will use it too😎. Otherwise, I think your solution is really great, I appreciate the hard work! Kudos! Keep on coding!
Marked as helpful1@SenatriusPosted about 3 years ago@tesla-ambassador That is true about the main tags. Feel like I should have caught it, but these small mistakes tend to slip through anyway. Guess it comes with experience, thanks for pointing it out :)
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord