Design comparison
Solution retrospective
Any feedback is appreciated. Thanks
Community feedback
- @HYDROCODERPosted over 3 years ago
Hey there! The solution works and looks good! There are a few suggestions I would suggest if you don't mind:
-
When user clicks on the input fields of number of people or bill amount, a border appears and it sort of shifts everything and alters the placement slightly. You can use a box-shadow instead to achieve that effect.(inset type box-shadow)
-
When reset is clicked, the tip percent previously selected is not unchecked again, so I would suggest to remove the class "splitter__tip--active" from the button by adding a few more line of js in your reset functionality. Also, you can disable the reset button once it is clicked.
Hope this helps :).
Marked as helpful1@jerry-the-kidPosted over 3 years ago@HYDROCODER Thanks for your advices. It's very helpful. I will use box-shadow instead of border. Remove active class to reset btn which i forgot. Thanks again
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord