Design comparison
Solution retrospective
Hi,
This is my first time making a React App by myself, and it's really fun and challenging. Since it's my first time doing ReactJS alone (not copying from any source), it's not a perfect solution and there might bugs (although I haven't spotted any) here and there; but it's still a really nice experience to me.
Any feedbacks that help me improve my solutions are welcomed! Have a nice day!
Community feedback
- @besttlookkPosted over 2 years ago
hi, Congratulations on completing your first react challenge. I like to point out few issues tho:
- Consider your desing when user give large input and also when result is high.Limit the decimal to atmost digit. You can use "toFixed(2)" method on number to do that.
- On entering higher number, number opverlap with the icon. try giving higher left padding to avoid that.
- Also give some upper limit for tip percentage.
Good luck, #happyCoding
Marked as helpful1@sqle157Posted over 2 years ago@besttlookk Hi,
-
I did use toFixed(2) to limit the digit of the results on the right side.
-
I forgot about this one! Thank you for pointing that out, I will fix that right away
-
I will try this one out!
Thank you for your feedback! It was a really helpful one
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord