Tip Calculator App Using React JS and Sass

Community feedback

• 

  Marius Fagerland•125

  @mariusfaPosted over 3 years ago

  Just for info: In a larger project you would not import all your svg files in app component. You would import them in the component where they are used.

  For screenreaders/accessability reasons your input/labels are missing for/name pairs.

  <label for="bill">Bill</label>
  <input  name="bill" type="number"/>
  

  In react for => htmlFor

  Also notice the type="number". This might remove your regex tests. This also makes phone pull up the number keyboard for the input field.

  Testet the site. Works like a charm and you nailed the styling :)

  Marked as helpful

  3

  ---

  

  Darren Bawag•115

  @darrenbawagPosted over 3 years ago

  @mariusfa Thanks for the suggestion :) great help

  0
• 

  Liam R•425

  @Cooly-o-CatsPosted over 3 years ago

  Great Work! Few Suggestions: 1 - Reduce the white space at the top to allow it to be close to the design. 2 - In the design, there is a state and a message when input fields are blank, Could you do this?

  1