Tip calculator app Using Javascript

Community feedback

• 

  edouard herrengt•970

  @EdouardHrgtPosted over 2 years ago

  People number input should be a type Number not a type text as user should be onluy able to put a positive integer. Inputs borders are looking a bit heavy to me, maybe thin it could improve your global design.

  What you could add :

  • Hover effect color on the percentage buttons should stay when users click on it to show what amount is currently selectd

  • Error messages under inputs to precise what type of values aren't allowed

  0

  ---

  

  umar453•130

  @umar453Posted over 2 years ago

  @EdouardHrgt Thanks and what are your views about my challenge its my first JavaScript challenge?

  0

  

  edouard herrengt•970

  @EdouardHrgtPosted over 2 years ago

  @umar453 You mainly need to learn about handling errors and display them in the dom. Every time you'll use inputs in an app, you will need to filter what user's will put in it. Sart by reading more about html validation api ( required, min/max length, types etc.. then how to add a message in the dom (createElement, appendChild and how to toggle a class in the dom )

  Over all it's pretty good as a first project. Feel free to look at my version that was my first real use of JS too :-)

  0