Skip to content
Submitted almost 3 years ago

Tip calculator app using Html Sass and Javascript

Ronel Florida•450
@Ronel028
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Community feedback

  • Anosha Ahmed•9,300
    @anoshaahmedPosted almost 3 years ago

    To avoid accessibility issues in the future:

    • wrap everything in your body in <main> OR give role="" to the direct children of your <body> ... Click here to read more
    • have at least one <h1> in your code

    Good job! :)

    Marked as helpful
    0
    Ronel Florida•450
    @Ronel028Posted almost 3 years ago

    @anoshaahmed Thank you so much for the tips :)

    1
  • Siege•520
    @idesmarPosted almost 3 years ago

    Hi Ronel, Congratiolations in completing this project! The site looks great on mobile and desktop view. Your code looks clean and understandable.

    Just a few feedback on HTML that wasn't covered by the report generated by FEM regarding <small>. Although this is allowed, it goes against the principle of separation of concern. So even if it's allowed, taking SOC into consideration is always a good thing to bear in mind. Click here to read more about the <small> tag.

    Regarding landmarks, you may want to use <header> to contain the logo and <main> for the rest. That should fix some of the landmark concerns on your page.

    For JS, perhaps, create a return where if output is NaN, it won't change textContent or something similar.

    Great work and Happy coding!

    Marked as helpful
    0
    Ronel Florida•450
    @Ronel028Posted almost 3 years ago

    @idesmar Thank you :)

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord