Tip Calculator App - Srikar Topella ( Check It )

Community feedback

• 

  Sebastian Porini•265

  @zebokPosted over 3 years ago

  Hey Srikar! Well done mate! The layout looks good and the calculator works perfect. I like all the hover/focus effects and the bug report button.

  I just have 2 little comments.

  1: You should not use the same ID twice. IDs are meant to me unique. You are using the id "btn" for all the buttons. This is not the best approach.

  2: When i click the anchor tag "Srikar Topella" rigth at the bottom of the page, it returns me to the same page. It would we better if you could redirect that link right to your github profile or your personal website.

  Thats all mate! Well done! Keep practising. Some day we will be experts doing this :)

  Marked as helpful

  1

  ---

  

  Srikar Topella•160

  @srikartopellaPosted over 3 years ago

  @zebok Comment 1 : Perfect ,thanks, I actually know that but, when I'm writing css I forgot to add classes to buttons and If I change any CSS I need to rewrite the entire component I've already worked so much and tired , so I had to make that id thing up , Anyway thanks comment 2 : I'm doing it now I forgot when I'm commiting

  0

  

  Srikar Topella•160

  @srikartopellaPosted over 3 years ago

  @zebok fixed both of them mate thanks for your opinion and your appreciation I appreciate both of them.It means alot.

  0

  

  Sebastian Porini•265

  @zebokPosted over 3 years ago

  @srikar8141

  I’m answering you from my phone. And I took a look on the website.

  Works perfectly on phone.

  I love the smooth transition when the user pick the tip percentage. Awesome touch.

  I see you have also linked you Github profile. Well done mate. Cheers!

  0