Tip calculator app solution

Community feedback

• 

  hardy•3,660

  @hardy333Posted about 3 years ago

  Hi, your solutions looks good, nicely done.

  Some suggestions for design:

  • Try to use font-weight: 700; on your reset button, and change it's color to very-dark-blue color or whatever it is in style guide.
  • Other then that design looks perfect...

  For Logic and js:

  • Try to not validate inputs too early, for example if I choose 10% of tip without firstly choosing - total bill, total bill input shows invalid - red outline which is not quite good UX. So in js try to firstly collect all three information: bill, tip and person count and only after that calculate, cost on one person...

  2

  ---

  

  Sky•120

  @sky-1991-siaPosted about 3 years ago

  @hardy333 I don't have premium account(Figma file) so I must discover everything from a design png, about colors and font sizes its some messy to find exactly details, thank you for helping

  1

  

  Sky•120

  @sky-1991-siaPosted about 3 years ago

  @hardy333 I'm new in coding, I'm nervous about my codes to be clean or not, do you think my code is ok and clean?

  1
• 

  Sky•120

  @sky-1991-siaPosted about 3 years ago

  hi, I have an issue, after I submitted my solution found some difference between my solution and design so I fixed them and pushed the edited file to Github, now it's ok in live preview but in my frontend mentor solution preview it didn't change, and look like the first version of my solution, why it doesn't change with changing the Github repository?

  0

  ---

  

  hardy•3,660

  @hardy333Posted about 3 years ago

  @sky-1991-sia Hi, try to change name of your main css file, one reason why that is happening is that your files could be cashed ...

  0

  

  Sky•120

  @sky-1991-siaPosted about 3 years ago

  @hardy333 thank you, I did that and I changed my js and CSS file names and push them again, but in front end mentor it's as same as before and my solution preview didn't change, its a disadvantage for this site I think, cuz after the first solution submit we cant submit any change on that

  0