Design comparison
SolutionDesign
Solution retrospective
My Desktop design is not that great. This project helps me practice my javascript knowledge. Any feedback is welcomed.
Community feedback
- @NaveenGumastePosted over 2 years ago
Hay ! Kunal Good Job on challenge
-> Just one thing use
h1
first and thenh2
,h3
and so on-> Check my article on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful1@kunals741Posted over 2 years ago@Crazimonk Thank you for the advice. I fixed those issues now. 🙂
1 - @ChamuMutezvaPosted over 2 years ago
Greetings Kunal.
- some of the images here are just for decorative purposes and should therefore have an empty alt value, For example values like
person-sign, dollar-sign
. - input elements such as
<input type="number" class="ip" placeholder="0" id="billValue">
, should be associated with a label for accessibility. An input element without a label does not clearly inform the user of what is expected to do. - all the percentages should have been interactive elements, the li elements you used will not be accessible when using a keyboard. An element such as a button is appropriate.
- the calculator is not working as i would expect, it seems the results are only updated when i change the number of people buy when i change the bill amount or the percentages , nothing happens.
0 - some of the images here are just for decorative purposes and should therefore have an empty alt value, For example values like
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord