Tip Calculator App | Mobile First Workflow

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Kunal Good Job on challenge

  -> Just one thing use h1 first and then h2, h3 and so on

  -> Check my article on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  Marked as helpful

  1

  ---

  

  Kunal•105

  @kunals741Posted almost 3 years ago

  @Crazimonk Thank you for the advice. I fixed those issues now.  🙂

  1
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted almost 3 years ago

  Greetings Kunal.

  • some of the images here are just for decorative purposes and should therefore have an empty alt value, For example values like person-sign, dollar-sign.
  • input elements such as <input type="number" class="ip" placeholder="0" id="billValue">, should be associated with a label for accessibility. An input element without a label does not clearly inform the user of what is expected to do.
  • all the percentages should have been interactive elements, the li elements you used will not be accessible when using a keyboard. An element such as a button is appropriate.
  • the calculator is not working as i would expect, it seems the results are only updated when i change the number of people buy when i change the bill amount or the percentages , nothing happens.

  0

  ---

  

  Kunal•105

  @kunals741Posted almost 3 years ago

  @ChamuMutezva Thank you for your advice.

  0